docs: Clarify FunctionalDependence::nullable and Dependency mode docs#23635
Open
alamb wants to merge 1 commit into
Open
docs: Clarify FunctionalDependence::nullable and Dependency mode docs#23635alamb wants to merge 1 commit into
FunctionalDependence::nullable and Dependency mode docs#23635alamb wants to merge 1 commit into
Conversation
… docs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23635 +/- ##
=======================================
Coverage ? 80.65%
=======================================
Files ? 1086
Lines ? 366097
Branches ? 366097
=======================================
Hits ? 295268
Misses ? 53236
Partials ? 17593 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alamb
changed the title
FunctionalDependence::nullable and Dependency mode docsFunctionalDependence::nullable and Dependency mode docs
alamb
marked this pull request as ready for review
July 16, 2026 11:44
Contributor
Author
|
@mustafasrepo / @akurmustafa as the original author of these structures, I wonder if you might have some time to review some comment improvements? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While working on #23548 / #23634 I found the existing comments on
FunctionalDependence::nullableeasy to misread: "whether the source columns can receive NULL values" suggests the flag tracks field nullability, when what all consumers actually rely on is whether the same NULL-containing key may occur in multiple rows (the SQLUNIQUEsemantic, where NULLs compare distinct).What changes are included in this PR?
Comment-only changes to
datafusion/common/src/functional_dependencies.rs:Are these changes tested?
No code changes; covered by existing tests.
Are there any user-facing changes?
No behavior changes; improved rustdoc on public items.